Skip to content

get rid of inet_addr usage #6948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

remicollet
Copy link
Member

@nikic following pr #6944

P.S. notice litespeed is broken... will see if can fix it in another unrelated PR

@remicollet
Copy link
Member Author

remicollet commented May 6, 2021

@cmb69 there is some inet_addr usage in win32/sendmail.c and win32/inet.c, don't know if worth to be fixed there

@cmb69
Copy link
Member

cmb69 commented May 6, 2021

From a quick glance, it seems we can drop win32/inet.c/.h altogether, since this has only a fallback definition of inet_aton; or do we need to support it for external extensions?

GetAddr() in win32/sendmail.c should be fixed (it currently doesn't support IPv6). Or maybe drop SMTP support altogether? (It's hard to maintain that Windows specific implementation in the long run.)

@remicollet remicollet requested a review from nikic May 6, 2021 12:49
@remicollet remicollet requested a review from nikic May 6, 2021 13:56
@remicollet
Copy link
Member Author

@nikic thanks :)

Merged as e5b6f43

@remicollet remicollet closed this May 6, 2021
@remicollet remicollet deleted the issue-inet-addr branch May 6, 2021 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants